Thinking About Using VBA's IsNumeric Function? Read this first.

I have posted the following many times over the last 15 years or so in responding to old newsgroup and current forum questions. I decided to post it here for all to see.

I usually try and steer people away from using IsNumeric to "proof" supposedly numeric text. Consider these (also see note below):

ReturnValue = IsNumeric("($1,23,,3.4,,,5,,E67$)")

ReturnValue2 = IsNumeric("&HEAD")
        

Most people would not expect THOSE to return True. IsNumeric has some "flaws" in what it considers a proper number and what most programmers are looking for.

I had a short tip published by Pinnacle Publishing in their Visual Basic Developer magazine that covered some of these flaws. Originally, the tip was free to view but is now viewable only by subscribers. Basically, it said that IsNumeric returned True for things like -- currency symbols being located in front or in back of the number as shown in my example (also applies to plus, minus and blanks too); numbers surrounded by parentheses as shown in my example (some people use these to mark negative numbers); numbers containing any number of commas before a decimal point as shown in my example; numbers in scientific notation (a number followed by an upper or lower case "D" or "E", followed by a number equal to or less than 307 -- the maximum power of 10 in VB); and Octal/Hexadecimal numbers (&H for Hexadecimal, &O or just & in front of the number for Octal).

NOTE: In the above example and in the referenced tip, I refer to $ signs and commas and dots -- these were meant to refer to your currency, thousands separator and decimal point symbols as defined in your local settings -- substitute your local regional symbols for these if appropriate.

As for the question about checking numbers, here are two functions that I have posted in the past for similar questions.... one is for digits only and the other is for "regular" numbers (the code is simple enough that it can be pulled from the function "housing" and used directly inside your own code):

Function IsDigitsOnly(Value As String) As Boolea
??IsDigitsOnly = Len(Value) > 0 And Not Value Like "*[!0-9]*"
End Function

Function IsFloatingPoint(ByVal Value As String) As Boolean
  '??Leave the next statement out if you don't
??'??want to provide for plus/minus signs
??If Value Like "[+-]*" Then Value = Mid$(Value, 2)
??IsFloatingPoint = Not Value Like "*[!0-9.]*" And _
                    Not Value Like "*.*.*" And _
                    Len(Value) > 0 And Value <> "."
End Function        

Here are revisions to the above functions that deal with the local settings for decimal points (and thousand's separators) that are different than used in the US (this code works in the US too, of course).

Function IsNumber(ByVal Value As String) As Boolea
? Dim DP As String
 ?'??Get local setting for decimal point
 ?DP = Format$(0, ".")
 ?'??Leave the next statement out if you don't
 ?'??want to provide for plus/minus signs
 ?If Value Like "[+-]*" Then Value = Mid$(Value, 2)
 ?IsNumber = Not Value Like "*[!0-9" & DP & "]*" And Not Value Like "*" & _
      ???????DP & "*" & DP & "*" And Len(Value) > 0 And Value <> DP
End Function        

I'm not as concerned by the rejection of entries that include one or more thousand's separators, but we can handle this if we don't insist on the thousand's separator being located in the correct positions (in other words, we'll allow the user to include them for their own purposes... we'll just tolerate their presence).

Function IsNumber(ByVal Value As String) As Boolea
 ?Dim DP As String
 ?Dim TS As String
 ?'??Get local setting for decimal point
 ?DP = Format$(0, ".")
 ?'??Get local setting for thousand's separator
 ?'??and eliminate them. Remove the next two lines
 ?'??if you don't want your users being able to
 ?'??type in the thousands separator at all.
 ?TS = Mid$(Format$(1000, "#,###"), 2, 1)
 ?Value = Replace$(Value, TS, "")
 ?'??Leave the next statement out if you don't
 ?'??want to provide for plus/minus signs
 ?If Value Like "[+-]*" Then Value = Mid$(Value, 2)
 ?IsNumber = Not Value Like "*[!0-9" & DP & "]*" And Not Value Like "*" & _
      ???????DP & "*" & DP & "*" And Len(Value) > 0 And Value <> DP
End Function        
Vinamra Chandra

AVP - Global Procurement Services at State Street

2 年

Thank you.

回复

要查看或添加评论,请登录

Rick Rothstein的更多文章

  • The SplitTo Function...

    The SplitTo Function...

    ***** EDIT NOTE ***** The original formula in this article had a minor error which has now been corrected. If you…

    9 条评论
  • TEXT Function Array Argument

    TEXT Function Array Argument

    Victor Momoh (MOS,R.Eng) posted an article/video (see link below) which explains that the TEXT function can use an…

    2 条评论
  • Get Random Number Of Unique Items From A Range Or An Array

    Get Random Number Of Unique Items From A Range Or An Array

    A few weeks ago, I posted an article showing how to get one or more non-repeating random numbers between a specified…

    17 条评论
  • Color Constants For Use In VBA Code

    Color Constants For Use In VBA Code

    There are eight pre-defined color constants in VBA which can be used directly without knowing their underlying numeric…

    3 条评论
  • Find Text Matching A Specified Pattern

    Find Text Matching A Specified Pattern

    Yesterday (December 12, 2021), I posted a post that contained a function to find text that matched a given pattern…

    5 条评论
  • YES, formulas CAN change values in OTHER cells!

    YES, formulas CAN change values in OTHER cells!

    Okay, one thing we have been told over and over again is that a formula, even a UDF (user defined formula) cannot put a…

    10 条评论
  • A Neat Goto Selector

    A Neat Goto Selector

    Quite awhile ago, a thread on a forum I used to volunteer at asked how to implement the mouse scroll wheel inside a…

社区洞察

其他会员也浏览了