How do you perform code reviews and peer feedback for your automation code?

When performing code reviews for automation code, focus on 1. Readability 2. Maintainability 3 Adherence to coding standards Check for 1. Proper comments 2. Clear variable/function names Provide specific feedback and suggest improvements to enhance code quality.

I prefer to implement automatic and manual reviews for my project code. The automatic review is done by code formatter and prettier tools. I configure the git repository in such a way that it will not allow anyone to commit code locally or create a merge request if there are code formatting issues. This will ensure code is maintaining the guidelines and standards. Next the Git configuration should enforce reviews by a set of experts in the team. Here we can implement a rule of multiple reviewers. The reviewers will check the code on the following aspects 1. Algorithm 2. Locator values 3. Appropriate use of library and utilies of the framework 4. Completion of assertions as per the test case.

During Code Review Process we can keep following things in mind 1. Code is clean and well formatted 2. Code follows coding standards as defined by the organisation like the format of class name, method Name etc. 3. Code is well tested to avoid syntax errors/logical errors. Use automated tools to analyse the code. 4. Code is up to date with the master branch. 5. Code should be successfully executed at least once before raising a PR.

In my opinion, addition to the points mentioned, Test evidence should be attached to the PR. I.e. Test report or screenshots depicting code is tested

Preparing for code reviews and peer feedback is crucial for improving the overall quality of your code. Here are some tips to help you prepare effectively: ### Before Submitting Code for Review: 1. Understand the Requirements 2. Code in Small, Understandable Units 3. Follow Coding Standards 4. Write Meaningful Comments 5. Run Tests 6. Check for Code Smells 7. Self-Review ### During the Code Review: 1. Be Open to Feedback 2. Communicate Clearly 3. Take Breaks 4. Be Responsive ### After the Code Review: 1. Learn from Feedback 2. Iterate and Improve 3. Express Gratitude 4. Reflect on the Process

Ensuring your code is review-ready involves meticulous local testing, adherence to best practices in your automation framework, and employing tools for static code analysis. Eliminating redundancy and unnecessary complexity through refactoring, along with comprehensive commenting and documentation, enhances the clarity and maintainability of your code. This proactive approach facilitates smoother collaboration and improves the overall quality of your software.

Before Submitting Code for Review: 1. Understand the Requirements 2. Follow Coding Standards 3.Dry run the code 4.Self-Review 5.Run static code analysis tools:Sonarcube 6.Refactor your code During code review 1.Be a open learner and accept mistake and change the code according to the comment 2.Be a soft learner 3.Be more productive and responsive about their work After code review: 1.Learn from feedback 2.Understand what approach reviewer use for reviewing the code 3.Be a learner and take all response positively

Framework code should be layered separately from business logic, just like any regular application. And that must be commented thoroughly. Test automation code should be simple in the sense of how we drive it in the “frontend” portion (the business case), which then avoids clustering the project with unnecessary code.

Some of the important points here: 1. Clear objectives:By clearly communicating the goals and expectations of the code review.This could include checking for bugs, ensuring adherence to coding standards, and promoting code readability 2. Coding standards:Ensure team follows proper coding standards which includes naming conventions, code reusability, formatting etc

Use tools like azure DevOps or GitHub to execute code reviews. Establish approval rules over Pull Requests and do not allow code to be merged to main or develop branches until it has been accepted. Establish comments in the tool to allow historical track of those code reviews.

Feedbacks are very much valuable and it adds to your learning. We should take it positively with a learning attitude. Feedbacks helps to increase the code quality only. one should not blindly follow the feedback instead if not clear and not satisfied we should connect with the peer and understand the need of change

Any feedback is valuable especially when it comes from your coworkers. Feedbacks increase the interaction. Companies emphasise the value of getting and giving feedback would get better environment and realise the problems before getting bigger.

I always recommend team members to join together in a quick peer review meeting after the code review comments have been outlined. This avoids unnecessary back-and-forth though email and accelerates correction of the code per expectations of both the reviewer and the developer.

Encourage Discussion Use Code Linters and Analyzers Effective Communication Learn from Feedback Provide Actionable Feedback Continuous Learning

Adhere to coding standards and conventions to allow coding solutions for test automation to be driven by a pattern that makes sense. Without standardization, the solution will eventually become a cluster of nonsensical logic that would be difficult to interpret.