You're struggling to give feedback on code. How can you do it constructively?

I like to use the mantra "carrot, stick, carrot" - make the first thing they see be a positive comment (even if it's just thanking them for taking initiative etc), then the technical feedback/suggestions, then close with another positive comment (e.g. even a simple "Thanks again!"). This works in many other scenarios as well, such as bug reports, email conversations, etc etc.

Empthy is very important, as the person who has coded with the frame of mind is different then what reviewer thinks. Always apperecite the developer how its coded we need to understnad the intenation behind the code rather then giving lot of suggestions which will create a confusion to developers. As a reviewer need to expaling the imapct of the code in long run and how it can be done better by sharing the technial knowledge. at the end of the day developer get motivations from learing. if we ensure that from the review the developer learned then they alway request for code review.

When giving feedback on code, start by acknowledging the effort and recognizing what was done well, such as clear variable names or a creative approach. Be curious and ask questions to understand the coder’s thought process before suggesting changes, framing your feedback as helpful suggestions rather than criticisms. Focus on the code, not the individual, and be specific about what could be improved, offering concrete examples or alternatives. Finally, express willingness to collaborate, reinforcing that you’re on the same team and supporting their growth and learning.

Além de praticar empatia, experimente se oferecer para fazer um "pair programming" em que você e o autor do código trabalham juntos para refinar o trecho em quest?o. Isso transforma o feedback em uma experiência colaborativa e prática, permitindo que você demonstre sugest?es em tempo real. Ao trabalhar lado a lado, o autor pode aprender diretamente com suas ideias, e você também pode ganhar uma nova perspectiva sobre o código e suas decis?es.

You start by saying "it looks perfect". That's it. Second time you talk about it - you can provide some feedback in a form of suggestions.

Para aumentar a clareza do seu feedback, considere anexar exemplos concretos ou snippets de código que ilustram suas sugest?es. Em vez de apenas apontar problemas, mostre alternativas que melhorariam a legibilidade ou a eficiência. Usar ferramentas de revis?o de código que permitem comentários em linha pode ajudar a contextualizar suas observa??es, tornando-as mais relevantes e fáceis de entender para o autor.

Providing a clear, direct critique that focuses on the code rather than the coder is the kindest way to give feedback. If you hide your concerns behind vague language in an effort to protect the author's feelings, you'll leave them wondering about what exactly is wrong with the code and what changes you expect to see. Be as specific as possible in asking for changes, and explain the reason for each change.

Using Nonviolent Communication (NVC) is crucial when giving feedback and requesting code changes, especially when working with new team members or people from outside your team. Since people often take code requests personally, NVC helps ensure that feedback is constructive, respectful, and fosters a positive, collaborative environment.

One way to show respect is to acknowledge and accept the things that work, even if you might have done them differently. Saying "It wouldn't have occurred to me to take this approach, but it works well and I like it" where appropriate can help a new contributor feel appreciated.

Vá além de simplesmente encorajar perguntas. Proponha uma sess?o de revis?o onde o autor do código possa apresentar suas decis?es e você possa discutir as sugest?es ao vivo. Isso n?o só facilita o entendimento mútuo, mas também promove uma troca de conhecimentos onde ambos podem aprender algo novo. Essa abordagem ajuda a construir uma rela??o de confian?a e torna o processo de feedback mais interativo e enriquecedor.

Respectfully question any implementation details or language features you're unfamiliar with during code reviews. These inquiries often lead to valuable discussions that can enhance the overall quality of the solution and even uncover potential bugs before they reach QA. Asking questions is not just about seeking clarity—it's a vital part of the review process that drives better outcomes and fosters a culture of continuous learning.