What are some effective ways to give feedback on code?

Getting the right context of the code is critical before beginning to review the code. 1. Ensure you are well prepared by going over the stories/tasks associated to code review. 2.Clearly understand the requirement and do not hesitate to ask clarifying question when unsure. 3. Run and test the code by pulling down the branch to make sure the changeset does what's it suppose to do. 4. Dedicate uninterrupted focus time for code reviews to get the most out of the exercise

One code review policy that I find helpful is to always either explicitly approve the code or request specific changes. This prevents the scenario where the code author is unsure if their code has been approved as-is or what changes need to be made before it will be approved. Of course there are exceptions, like if a developer is looking for feedback on code that isn't finished yet, but they can easily be indicated using labels or PR naming conventions.

?? Highlight strengths: "Great use of functions!" ? Clarify intent: "What's the purpose of this loop?" ?? Point out issues: "Variable naming can improve for clarity." ?? Suggest fixes: "Consider using a dictionary here." ?? Offer to help: "Need assistance? Let's pair program." ?? Review changes: "Let's revisit after updates."

Using clear language is particularly crucial in globally distributed teams, humor and sarcasm may not translate well and your response may be run through Google Translate prior to reading. For respectful code feedback in these situations: Be Specific and Constructive: Offer clear, constructive suggestions rather than vague critiques. Focus on Code, Not the Person: Direct feedback at the code to avoid personal misunderstandings. Use Positive Language: Employ positive or neutral language to maintain a supportive tone. Acknowledge Cultural Differences: Be mindful of cultural sensitivities and communication styles. Encourage Dialogue: Invite questions to foster open, collaborative communication.

A respectful and constructive tone fosters an environment of trust and openness, encouraging collaboration and learning. When giving feedback on code, such a tone helps to avoid defensiveness and encourages the recipient to consider suggestions objectively. It promotes a positive mindset, motivating individuals to strive for improvement rather than feeling discouraged by criticism. By focusing on the code's merits and areas for enhancement, a respectful tone ensures that feedback is well-received and actionable, leading to more effective problem-solving and skill development within the team.

Lo principal a la hora de emitir cualquier tipo de opinión, es dar a entender que se hace de forma constructiva, buscando que la otra persona refuerce lo que hizo correctamente y pueda mejorar en lo que no lo hizo del todo bien. De esta forma la otra persona va a estar predispuesta a escucharte de forma activa e incluso hacer consultas sobre las mejores prácticas o estándares que se manejen en la organización.

- Always judge the code, not the person who wrote it. - Work through a common goal of delivering value. - If you have nitpicks as opinions coment it but you shouldn't block a Pull Request by those. - Elaborate and include concepts that the person you are working with might not be familiar with, so they can be on the same page you are talking about.

When giving feedback on code, be specific and actionable 1. Be Clear: - Instead of vague comments, pinpoint exact areas for improvement. 2. Offer Solutions: - Don't just highlight issues; suggest specific fixes or improvements. 3. Use Examples: - Identify problems with specific lines or elements in the code. 4. Encourage Best Practices: - Recommend adhering to coding standards and best practices. 5. Provide Positive Feedback: - Acknowledge what's done well in addition to pointing out improvements. So that your feedback becomes more helpful, guiding developers toward concrete enhancements and fostering a positive learning environment.

Balancing positive and negative comments in code feedback is crucial for maintaining morale and fostering growth. Positive remarks acknowledge strengths, boosting confidence and reinforcing good practices. They highlight what's working well and encourage continued progress. Conversely, negative comments address areas for improvement, guiding developers toward better solutions and refining their skills. By striking this balance, feedback remains constructive rather than discouraging. It emphasizes achievements while offering clear pathways for enhancement, ensuring that developers feel supported and motivated to grow without becoming overwhelmed by criticism.

Asking questions and inviting dialogue in code feedback fosters a collaborative atmosphere where ideas can be shared and understood. It encourages developers to articulate their thought processes, promoting deeper understanding and exploration of alternative solutions. By asking clarifying questions, feedback providers gain insights into the reasoning behind certain coding decisions, facilitating more targeted and constructive suggestions. Moreover, inviting dialogue invites recipients to express their perspectives and concerns, fostering mutual respect and trust.

Una de las mejores formas de que una persona adquiera conocimiento es que lo haga por sus propios medios. Indicar que algo está erroneo, demostrar el motivo y proveer herramientas para encontrar otra alternativa es mucho mejor que simplemente dar la respuesta correcta. Realizar este proceso de forma recurrente en las revisiones de código, va a permitir que la persona misma encuentre sus errores, los identifique y tenga opciones para solucionarlo y, eventualmente, solo recurrir al experto cuando se le acaben las ideas.

Few other that can help in code review process: 1. Do not hold up the review for no good reason (this is negatively impact the code review process. For Example, there are chances to have more merge request to be reviewed, waiting merely for the preference is waste of everyone's time) 2. Don't go beating around the bush (Don't just keep adding comments over new stuffs or trying to make code 100% perfect) 3. Always proofread your comments/suggestions before submitting the review

Most engineers don't talk enough about Engineering Empathy. They should. Recognizing and understanding the end-users' perspectives, challenges, and experiences is not just a soft skill; it's a fundamental aspect that can significantly enhance the effectiveness and impact of engineering solutions.

It's better practice to provide explanations when giving feedback. This helps in better understanding of the code scenario and its best approach. Following best practices consistently improves code quality and increases efficiency.