What are the most common mistakes when giving feedback on code?

1 Mistake 1: Not following a code review checklist

A code review checklist is a set of criteria that you use to evaluate the code before giving feedback. It helps you to be consistent, thorough, and objective, and to focus on the most important aspects of the code, such as functionality, readability, security, performance, and style. A code review checklist can also help you to avoid personal bias, subjective opinions, or irrelevant comments that can distract or confuse the author of the code. You can create your own code review checklist, or use an existing one, such as the Google code review guidelines or the Code Review Best Practices.

2 Mistake 2: Not providing enough context or explanation

When giving feedback on code, you should always provide enough context and explanation for your comments. This means that you should not only point out what is wrong with the code, but also why it is wrong, and how it can be improved. You should also provide examples, references, or links to support your feedback, and to help the author of the code understand your perspective and reasoning. Providing enough context and explanation can help you to avoid misunderstandings, conflicts, or resentment, and to foster a collaborative and respectful code review culture.

3 Mistake 3: Not prioritizing or categorizing your feedback

Not all feedback is equally important or urgent. Some feedback may be critical, such as fixing a bug or a security issue, while some feedback may be optional, such as improving a variable name or a comment. When giving feedback on code, you should always prioritize and categorize your feedback, so that the author of the code knows what to focus on first, and what to consider later. You can use labels, tags, or prefixes, such as "Must", "Should", "Nice to have", or "Question", to indicate the priority or category of your feedback. Prioritizing and categorizing your feedback can help you to avoid overwhelming, confusing, or discouraging the author of the code, and to facilitate a smooth and efficient code review process.

5 Mistake 5: Not being respectful or empathetic

When giving feedback on code, you should always be respectful and empathetic. This means that you should not use harsh, rude, or offensive language, such as "This code is garbage", "This code is a joke", or "This code is written by a beginner". Instead, you should use polite, professional, and constructive language, such as "This code has some issues", "This code can be improved", or "This code has potential". You should also acknowledge the effort, skill, and intention of the author of the code, and appreciate their contribution, such as "Thank you for your work", "I appreciate your creativity", or "I like your approach". Being respectful and empathetic can help you to avoid hurting, demotivating, or alienating the author of the code, and to build trust, rapport, and collaboration.