登录查看更多内容

What are the best ways to recover from a negative code review?

由人工智能和领英社区提供技术支持

Code reviews are an essential part of application development, as they help improve the quality, readability, and security of your code. However, not all code reviews are positive, and sometimes you may receive harsh or unfair feedback that can hurt your confidence and motivation. How can you recover from a negative code review and turn it into a learning opportunity? Here are some tips to help you cope and grow as a developer.

此文章中的业界达人

由社区从 5 条内容中精选。了解更多

Anuj Dhawan

Senior Architect | IBM Champion | DevOps | Mainframe Modernisation
Greg Bala

1 Acknowledge your emotions

The first step to recover from a negative code review is to acknowledge how you feel about it. You may feel angry, frustrated, embarrassed, or discouraged, and that's okay. These are natural reactions to criticism, especially if it's delivered in a rude or unconstructive way. However, don't let your emotions cloud your judgment or affect your work performance. Take some time to calm down, breathe, and process your feelings before you respond or take action.

添加您的观点

Greg Bala
举报内容
I have worked in customer support, one way or another for a good part of my life. In all cases, for a disgruntled customer, it is essential to listen to what they say, to how they feel, and acknowledge legitimate grievances and take ownership of mistakes on your end. This works pretty much in any relationship.

已翻译

赞
Benedict Mus?gi

Solution Architect
举报内容
Agreeing to the recommendation to take time to process emotions. It will be ideal if you are on good terms with the one giving the review, as it can be a good source of growth if you can work with one another to identify potential gaps and learning opportunities. From an artifact perspective, it's also a good opportunity to nip things in the bud, especially if you have emotions of "we've always done it a certain way", there may be signs of aging practices that could be improved, and this could be a step towards that.

已翻译

赞

2 Review the feedback objectively

The next step is to review the feedback objectively and try to separate the facts from the opinions. Look for specific and actionable suggestions that can help you improve your code, such as fixing bugs, refactoring, adding comments, or following best practices. Ignore any personal attacks, vague comments, or irrelevant remarks that don't add value to your code review. If you're not sure about something, ask for clarification or examples from the reviewer.

添加您的观点

Anuj Dhawan

Senior Architect | IBM Champion | DevOps | Mainframe Modernisation
举报内容
Receiving a negative code review can be disheartening, but it's crucial to view it as an opportunity for improvement. Firstly, take a step back to absorb feedback objectively, separating personal feelings from the critique. Prioritize addressing critical issues highlighted and consider the reviewer's perspective. Engage in a constructive dialogue with reviewers, seeking clarification on their concerns and discussing potential solutions. Utilize the feedback to enhance your coding skills and apply lessons learned to future work. Embrace the learning experience, demonstrating a proactive and growth-oriented attitude. Remember, turning a negative review into a positive outcome showcases resilience and a commitment to continuous improvement.

已翻译

赞
Benedict Mus?gi

Solution Architect
举报内容
It's good to ask questions to the reviewer to better understand their point. Understanding the basis of the review, such as an industry standard, actions to address regulatory compliance, tool-based review findings are good areas to start so one can also proactively review their work in the future. That said, we should understand the premise why these are important bases for compliance, quality, security, and so forth. Blindly following "rules" is an avenue for complacency, while also stifling innovation.

已翻译

赞

3 Learn from your mistakes

The third step is to learn from your mistakes and use the feedback to improve your skills and knowledge. Identify the areas where you need to work on, such as syntax, logic, design, testing, or documentation. Research and study the topics that you're not familiar with, and practice them on your own or with a mentor. Apply the changes that you agree with to your code, and test it thoroughly before submitting it again.

添加您的观点

Benedict Mus?gi

Solution Architect
举报内容
This can be applied proactively by reviewing other code artifacts that follow the same implementation pattern, and if necessary, work with the team to retrofit any changes that need to be implemented. Reviews, whether with a positive or negative outcome, are opportunities for us to prevent mishaps from happening or closing them before bigger issues arise. Even for code reviews with a positive outcome, we can flag new practices that we applied, which may not have been applied to historical code, but would solve / prevent problems come runtime.

已翻译

赞

4 Seek a second opinion

The fourth step is to seek a second opinion from another developer or a peer who can give you a different perspective on your code. This can help you validate your work, gain new insights, and discover alternative solutions. You can also ask them for advice on how to handle the feedback, or how to communicate with the reviewer. However, don't use this as an excuse to avoid or dismiss the feedback, or to start a conflict with the reviewer.

添加您的观点

5 Respond professionally

The fifth step is to respond professionally to the feedback and thank the reviewer for their time and input. Even if you disagree with some of the comments, don't argue, complain, or insult the reviewer. Instead, explain your reasoning, provide evidence, or ask for more information. Be polite, respectful, and constructive, and show that you're willing to learn and improve. If the feedback was rude or abusive, report it to your manager or a senior developer.

添加您的观点

6 Move on and grow

The final step is to move on and grow from the experience. Don't dwell on the negative feedback or let it affect your self-esteem or creativity. Remember that code reviews are not personal, and that every developer has room for improvement. Use the feedback as a catalyst for your growth, and keep working on your projects with passion and enthusiasm. You'll soon see the results of your efforts and become a better developer.

添加您的观点

7 Here’s what else to consider

This is a space to share examples, stories, or insights that don’t fit into any of the previous sections. What else would you like to add?

添加您的观点

Application Development

+ 关注

给文章评分

我们借助人工智能创建了此文章。您认为这篇文章怎么样？

很棒不太好

举报此文章

查看全部

What are the best ways to recover from a negative code review?

1

2

3

4

5

6

7

1 Acknowledge your emotions

2 Review the feedback objectively

3 Learn from your mistakes

4 Seek a second opinion

5 Respond professionally

6 Move on and grow

7 Here’s what else to consider

Application Development

给文章评分

感谢您的反馈

更多Application Development相关文章

更多相关阅读内容